Address SBI mpxy ARC feedback #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atishp04
reviewed
Jan 24, 2025
src/ext-mpxy.adoc
Outdated
| message protocol specification are also referred to as posted messages. This | ||
| function should be only used for such posted messages and the respective message | ||
| protocol specification should define a mechanism to track the status of posted | ||
| messages using notification events or some other message with response. |
There was a problem hiding this comment.
The 2nd part is optional - Correct ? Can we clarify that ? Something like this:
This function should be only used for such posted messages. The respective message
protocol specification should define a mechanism to track the status of posted
messages using notification events or some other message with response if required.
There was a problem hiding this comment.
Okay, I will update.
atishp04
reviewed
Jan 24, 2025
src/ext-mpxy.adoc
Outdated
| struct sbiret sbi_mpxy_get_shmem_size(void) | ||
| ``` | ||
|
|
||
| Get the shared memory size for sending and receiving messages. The shared memory |
There was a problem hiding this comment.
shared memory size in number of bytes ?
There was a problem hiding this comment.
Okay, I will update.
|
Apart from these nit comments, looks good to me. |
To address the ARC review feedback, improve notification related text as follows: 1) Replace the term "notification indication" with just "indication". 2) Minimize the use of term "client" and replace it with the term "supervisor software" at appropriate places to be consistent with other SBI extensions. Signed-off-by: Anup Patel <[email protected]> Reviewed-by: Rahul Pathak <[email protected]> Reviewed-by: Samuel Holland <[email protected]>
…onse() Based on ARC feedback, improve/clarify description of the SBI MPXY functions to send message with/without response. Signed-off-by: Anup Patel <[email protected]> Reviewed-by: Rahul Pathak <[email protected]>
The per-HART shared memory size must be greater than the biggest MSG_DATA_MAX_LEN attribute value across all MPXY channels so add a new separate SBI function to let supervisor software discover it. Signed-off-by: Anup Patel <[email protected]> Reviewed-by: Rahul Pathak <[email protected]> Reviewed-by: Samuel Holland <[email protected]>
avpatel
force-pushed
the
sbi_mpxy_arc_feedback_v3
branch
from
13ccdf2 to
e57e11e
Compare
|
@atishp04 I have addressed your comments. The build failure is due to some other issue. |
atishp04
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.