ext-sse: Fixes #194
Merged
ext-sse: Fixes #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only saying 'should' allows the implementation to not zero reserved bits, which means S-mode will need to do SBI version checks to determine whether or not future flags have meaning. Signed-off-by: Andrew Jones <[email protected]>
The abbreviation for identity number (ID) should be in caps. Signed-off-by: Andrew Jones <[email protected]>
Distinguish events / attributes from event IDs / attribute IDs by using 'ID' where appropriate. Signed-off-by: Andrew Jones <[email protected]>
Add some punctuation, remove some unnecessary text, and use future tense in a function description. Signed-off-by: Andrew Jones <[email protected]>
Replace uses of 'can' with 'must' or other verbs which indicate the behavior is absolute when the behaviors must be implemented. Signed-off-by: Andrew Jones <[email protected]>
To ensure SBI_ERR_INVALID_STATE is never returned for an invalid event ID, where SBI_ERR_INVALID_PARAM should be returned. Explicitly state that event_id is valid when SBI_ERR_INVALID_STATE is returned. Signed-off-by: Andrew Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.