target/riscv: make mem_access_result_t enum type safe #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fk-sc
force-pushed
the
fk-sc/type-safe-enum
branch
2 times, most recently
from
03ccc95 to
96fd974
Compare
There was a problem hiding this comment.
This style of error handling seems to be a bit unusual compared to the rest of OpenOCD codebase.
However, I understand why you did it like that and I don't mind this different style.
That being said, please could you add few comments, that explain why it is done this way. So that future readers do not have to wonder. Thanks.
fk-sc
force-pushed
the
fk-sc/type-safe-enum
branch
from
96fd974 to
58471e5
Compare
MarekVCodasip
previously approved these changes
Feb 20, 2025
Set appropriate memory access result codes Checkpatch-ignore: MACRO_ARG_PRECEDENCE, MULTISTATEMENT_MACRO_USE_DO_WHILE Checkpatch-ignore: TRAILING_SEMICOLON Change-Id: Ib73b5a041e5f15aef150b80fdd45f107de19d3a6 Signed-off-by: Farid Khaydari <[email protected]>
Make mem_access_result_t enum type safe and fix related problems Checkpatch-ignore: MACRO_ARG_PRECEDENCE, MULTISTATEMENT_MACRO_USE_DO_WHILE Checkpatch-ignore: TRAILING_SEMICOLON Change-Id: Ie5a8c71f3a8ad803f1660114c399c5a4dd0f7414 Signed-off-by: Farid Khaydari <[email protected]>
fk-sc
force-pushed
the
fk-sc/type-safe-enum
branch
from
58471e5 to
c14d9b6
Compare
MarekVCodasip
approved these changes
Feb 25, 2025
en-sc
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make mem_access_result_t enum type safe and fix related problems