New Bonsai Foundry Template #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capossele
commented
Jan 29, 2024
pdg744
reviewed
Jan 29, 2024
mothran
reviewed
Jan 29, 2024
pdg744
reviewed
Jan 29, 2024
Some minor link-changes to make the bonsai foundry template more cleanly integrate with our easiest-to-use reference materials on the dev docs site
* reword the opening statement for clarity and to make how the proofs get on-chain more ambiguous * make "publisher app" not a proper noun * add link to cargo-binstall * fixup install steps * consolidiate two steps for ease of copy-paste * fixups to the README to reflect the removal of the cli folder * make the test commands more visible * change deployment guide title and sort links * remove usage of docker from deployment guide * some fixes to the deployment guide * rename deployRiscZeroGroth16Verifier and elf.sol * rename elf.sol in gitignore * remove comment * remove the "early alpha" disclaimer
* remove shallow setting from gitmodules * add build steps and not codegen dependency * make the image ID a constant * adjust some comments * main does not need to be pub * fix up some typos and clippy errors * extract build functionality to risc0-ethereum * add some comments * scrub bonsai references * use RiscZeroCheats instead of BonsaiTest * remove test_SetOdd to avoid scary stderr output and because its a questionable test * extract MockRiscZeroVerifier.sol to risc0-ethereum * adjust README
Cardosaum
reviewed
Feb 23, 2024
Cardosaum
reviewed
Feb 23, 2024
Co-authored-by: Matheus Cardoso <[email protected]>
…capossele/no-relay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ethereum-sdk(This should be moved out from this repo)Closes risc0/risc0#1219
Closes risc0/risc0-ethereum#4