Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cargo.toml): use anton-rs repo for kona dependency #6

Merged

Conversation

samlaf
Copy link
Contributor

@samlaf samlaf commented Dec 22, 2024

https://github.com/ethereum-optimism/kona symlinks to https://github.com/anton-rs/kona, but it seems like Cargo doesn't understands this, because when importing our eigenda crate that points to the anton-rs repo, was hitting this bug:

cargo tree -i kona-proof     
error: There are multiple `kona-proof` packages in your project, and the specification `kona-proof` is ambiguous.
Please re-run this command with one of the following specifications:
  git+https://github.com/anton-rs/kona?rev=7a40d87#[email protected]
  git+https://github.com/ethereum-optimism/kona?rev=7a40d87#[email protected]

So changed all references to ethereum-optimism to point to the real anton-rs repo.

@samlaf samlaf requested a review from hashcashier December 22, 2024 00:58
Copy link
Collaborator

@hashcashier hashcashier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hashcashier hashcashier merged commit 954cb67 into risc0:main Jan 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants