fix arch not recognizing optional dependencies

[InnocentZero]

This fixes a bug where

Arch = [
	{ package = "pipewire", optional_deps = [
		"pipewire-alsa",
		"pipewire-jack",
		"pipewire-pulse",
		"wireplumber",         
		"libpulse",            
		"gst-plugin-pipewire",
	] },
]

does not recognize any of the optional dependencies.

[ripytide]

Why not use the existing map_managed_packages() function for this logic since these optional dependencies are a lot like groups in that they get expanded?

[InnocentZero]

I'm not entirely sure on how that function works and what it does, and more importantly, when I tried changing the signature to fit the requirements it basically became a giant mess. This seems simpler, but of course it could just be me misunderstanding what the function is doing once again.

[ripytide]

The function was needed since arch has two types of groups, meta-packages and just groups https://wiki.archlinux.org/title/Meta_package_and_package_group

So once you've installed a group it is as if you just installed a bunch of individual packages so then the pacdef clean would try and remove them all since it was not expecting them hence the need for us to expand the package groups before doing the checks for pacdef clean.

The signature for the function should not need to change, we take in the list of packages with groups un-expanded and output the expanded list. So we can expand out these dependencies at the same time.

[InnocentZero]

I figured it out. Thanks.

[ripytide]

Looks Good 👍