Improvement: Add the new 409 response documentation reflecting the addition of a cache_lock on PUT /1.0/identity_groups/:id . RD-24154 #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalilz4485
reviewed
Sep 5, 2024
specs/engage-digital_openapi3.yaml
Outdated
| '409': | ||
| description: >- | ||
| If the Identity Group is already being updated, it will return a 409 | ||
| error. |
There was a problem hiding this comment.
specs/engage-digital_openapi3.yaml:3411 used as a reference, honestly not much more thought than that went into it.
There was a problem hiding this comment.
you can remove it them, lets not copy weird things
|
Can you add a screenshot of the swagger view of the change ? |
|
The swagger preview didn't change after the last commit (f42a0c7). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the new response to make the clients aware that if they try to spam the PUT route, they can receive a 409 because the ressource will be locked while the 1st operation is being processed.