Skip to content

Commit

Permalink
installer: really default to Secure Channel
Browse files Browse the repository at this point in the history
Commit 8a7ab99 (installer: switch the libcurl default to Secure Channel,
2023-05-15) attempted to change the default libcurl backend for clean
new installs to Secure channel, but only adjusted one of two fallbacks
in the installer. There is one default value that gets passed to
ReplayChoice() to return if it finds no previous choice and one value
that gets used if ReplayChoice() returns an unexpected value. 8a7ab99
changed the latter to use Secure Channel, but left the former to default
to OpenSSL. Adjust the default value to match the intention of that
patch.

This fixes git-for-windows/git#5295

Signed-off-by: Matthias Aßhauer <[email protected]>
  • Loading branch information
rimrul committed Jan 4, 2025
1 parent d0d3260 commit f49e56f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion installer/install.iss
Original file line number Diff line number Diff line change
Expand Up @@ -2324,7 +2324,7 @@ begin
RdbCurlVariant[GC_WinSSL]:=CreateRadioButton(CurlVariantPage,'Use the native Windows Secure Channel library','Server certificates will be validated using Windows Certificate Stores.'+#13+'This option also allows you to use your company''s internal Root CA certificates'+#13+'distributed e.g. via Active Directory Domain Services.',TabOrder,Top,Left);
// Restore the setting chosen during a previous install.
case ReplayChoice('CURL Option','OpenSSL') of
case ReplayChoice('CURL Option','WinSSL') of
'OpenSSL': RdbCurlVariant[GC_OpenSSL].Checked:=True;
'WinSSL': RdbCurlVariant[GC_WinSSL].Checked:=True;
else
Expand Down

0 comments on commit f49e56f

Please sign in to comment.