Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add paging indicators #953

Merged
merged 5 commits into from
Jun 29, 2024
Merged

add paging indicators #953

merged 5 commits into from
Jun 29, 2024

Conversation

LEOYoon-Tsaw
Copy link
Member

This PR add paging indicator.

This is an opt-in feature. User can enable it by adding:

patch:
  style/show_paging: true

To minimize disruption and keep compact layout, it is shown outside of candidate panel. The paging arrows will align with first candidate, and is clickable. The roundedness follows highlighted candidate corner size.
It works under all other settings. A preview under horizontal linear layout is provided here, but other layouts also works:

Screen.Recording.2024-06-23.at.14.27.27.mov

Copy link
Member

@lotem lotem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice~

@LEOYoon-Tsaw LEOYoon-Tsaw merged commit 2adc436 into rime:master Jun 29, 2024
1 check passed
LEOYoon-Tsaw added a commit that referenced this pull request Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants