Fix SelectorItem with boolean value #2992
Annotations
4 errors and 7 warnings
Tests (net8.0):
src/Tests/ControlTests/AutoUIFormTests.cs#L38
Test method DotVVM.Framework.Tests.ControlTests.AutoUIFormTests.BulmaFormTest threw exception:
System.Exception: AutoUIFormTests.BulmaFormTest.html has changed, the actual output differs from the previous accepted output:
diff --git a/src/Tests/ControlTests/testoutputs/AutoUIFormTests.BulmaFormTest.html b/src/Tests/ControlTests/testoutputs/AutoUIFormTests.BulmaFormTest.html
index f3baa8b..0902e52 100644
--- a/src/Tests/ControlTests/testoutputs/AutoUIFormTests.BulmaFormTest.html
+++ b/src/Tests/ControlTests/testoutputs/AutoUIFormTests.BulmaFormTest.html
@@ -52,8 +52,8 @@
<div class="control">
<div class="select">
<select data-bind="dotvvm-validation: EnumProp, dotvvm-validationOptions: { invalidCssClass: "is-danger", setToolTipText: true }, value: EnumProp, valueAllowUnset: true" id="EnumProp__input">
- <option value="One">One</option>
- <option value="Two">Two</option>
+ <option data-bind="value: "One"">One</option>
+ <option data-bind="value: "Two"">Two</option>
</select>
</div>
</div>
Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file
|
Tests (net8.0):
src/Tests/ControlTests/AutoUIFormTests.cs#L48
Test method DotVVM.Framework.Tests.ControlTests.AutoUIFormTests.BootstrapFormTest threw exception:
System.Exception: AutoUIFormTests.BootstrapFormTest.html has changed, the actual output differs from the previous accepted output:
diff --git a/src/Tests/ControlTests/testoutputs/AutoUIFormTests.BootstrapFormTest.html b/src/Tests/ControlTests/testoutputs/AutoUIFormTests.BootstrapFormTest.html
index 366da8a..975dbac 100644
--- a/src/Tests/ControlTests/testoutputs/AutoUIFormTests.BootstrapFormTest.html
+++ b/src/Tests/ControlTests/testoutputs/AutoUIFormTests.BootstrapFormTest.html
@@ -20,8 +20,8 @@
<div class="mb-3">
<label class="form-label" for="EnumProp__input">Enum prop</label>
<select class="form-select" data-bind="dotvvm-validation: EnumProp, dotvvm-validationOptions: { invalidCssClass: "is-invalid" }, value: EnumProp, valueAllowUnset: true" id="EnumProp__input">
- <option value="One">One</option>
- <option value="Two">Two</option>
+ <option data-bind="value: "One"">One</option>
+ <option data-bind="value: "Two"">Two</option>
</select>
</div>
<div class="mb-3" data-bind="visible: $parent.Products()?.Items()?.length > 0">
Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file
|
Tests (net8.0):
src/Tests/ControlTests/AutoUITests.cs#L81
Test method DotVVM.Framework.Tests.ControlTests.AutoUITests.EnumEditor threw exception:
System.Exception: AutoUITests.EnumEditor.html has changed, the actual output differs from the previous accepted output:
diff --git a/src/Tests/ControlTests/testoutputs/AutoUITests.EnumEditor.html b/src/Tests/ControlTests/testoutputs/AutoUITests.EnumEditor.html
index e4cfa55..5bd205f 100644
--- a/src/Tests/ControlTests/testoutputs/AutoUITests.EnumEditor.html
+++ b/src/Tests/ControlTests/testoutputs/AutoUITests.EnumEditor.html
@@ -2,9 +2,9 @@
<head></head>
<body>
<select data-bind="value: Enum, valueAllowUnset: true">
- <option value="Case1">First Case</option>
- <option value="Case2">Second Case</option>
- <option value="Case3">Third Case</option>
+ <option data-bind="value: "Case1"">First Case</option>
+ <option data-bind="value: "Case2"">Second Case</option>
+ <option data-bind="value: "Case3"">Third Case</option>
</select>
</body>
</html>
Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file
|
Tests (net8.0)
Process completed with exit code 1.
|
Set up
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
|
Set up
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
|
Set up
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
|
Set up
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
|
Set up
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
|
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, nuget/setup-nuget@v1, actions/cache@v3, actions/setup-node@v3, actions/setup-dotnet@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "chrome-tests-Linux-Production-Default", "chrome-tests-Linux-Production-ExperimentalFeaturesTests", "chrome-tests-Windows-Development-Default", "firefox-tests-Linux-Development-Default", "firefox-tests-Linux-Development-ExperimentalFeaturesTests", "firefox-tests-Linux-Production-Default".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
|
The logs for this run have expired and are no longer available.
Loading