Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when using the flag --custom_builds_dir-enabled #357

Merged
merged 7 commits into from
Dec 5, 2024

Conversation

krousenick
Copy link
Contributor

This option for the gitlab-runner register command does not take any options/arguments. If you set it to true it breaks the registration of the runner.

.ansible-lint Outdated Show resolved Hide resolved
@guenhter
Copy link
Collaborator

guenhter commented Dec 5, 2024

LGTM.

When you are ready, I'm happy to merge.

@krousenick
Copy link
Contributor Author

This should also fix the ansible lint error for the 160 characters thing in defaults/main.yml:16. Take a look and let me know if you're ok with that.

@guenhter
Copy link
Collaborator

guenhter commented Dec 5, 2024

Very nice. Really appreciate that.

@krousenick
Copy link
Contributor Author

Ready to merge if you are!

@guenhter guenhter merged commit e15ea85 into riemers:master Dec 5, 2024
1 check passed
@guenhter
Copy link
Collaborator

guenhter commented Dec 5, 2024

Thx for this contribution

@krousenick krousenick deleted the fix-custom-builds-dir branch December 5, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants