-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gitlab server cert fix #356
Conversation
Seems very good. |
Sorry for so many commits, I was editing on the fly in the web gui. I am happy to fix what ever. |
I personally find many commits very good (In my daily work i often have more then 100 on the branch). But when the feature branch comes to an end, I appreciate to have useful commits (so properly squashed). |
No problem, I can squash my commits. |
…k/ansible-gitlab-runner into gitlab-server-cert-fix
Can you enable squash commits on merge in this repo's settings. It looks that will squash all these commits. https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/configuring-commit-squashing-for-pull-requests |
I don't have this power on that repo. |
…k/ansible-gitlab-runner into gitlab-server-cert-fix
Using the gitlab url rather than the ip as the gitlab server may have multiple virtual hosts for registry or pages or mattermost running and would have separate certs.