Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab server cert fix #356

Closed
wants to merge 21 commits into from

Conversation

krousenick
Copy link
Contributor

Using the gitlab url rather than the ip as the gitlab server may have multiple virtual hosts for registry or pages or mattermost running and would have separate certs.

@krousenick krousenick marked this pull request as ready for review December 3, 2024 20:22
defaults/main.yml Outdated Show resolved Hide resolved
tasks/register-runner.yml Outdated Show resolved Hide resolved
tasks/register-runner.yml Outdated Show resolved Hide resolved
@guenhter
Copy link
Collaborator

guenhter commented Dec 5, 2024

Seems very good.
When you are ready and the commits are as you want them to be (I guess this change is not worth 14 commits), I'm happy to merge.

@krousenick
Copy link
Contributor Author

Sorry for so many commits, I was editing on the fly in the web gui. I am happy to fix what ever.

@guenhter
Copy link
Collaborator

guenhter commented Dec 5, 2024

I personally find many commits very good (In my daily work i often have more then 100 on the branch). But when the feature branch comes to an end, I appreciate to have useful commits (so properly squashed).

@krousenick
Copy link
Contributor Author

No problem, I can squash my commits.

@krousenick krousenick marked this pull request as draft December 5, 2024 06:43
@krousenick
Copy link
Contributor Author

Can you enable squash commits on merge in this repo's settings. It looks that will squash all these commits. https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/configuring-commit-squashing-for-pull-requests

@guenhter
Copy link
Collaborator

guenhter commented Dec 5, 2024

I don't have this power on that repo.

@krousenick krousenick closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants