Fix linting issues #312

gardar · 2024-01-23T11:23:06Z

fixes: #283

Signed-off-by: gardar <[email protected]>

meta/main.yml

Signed-off-by: gardar <[email protected]>

guenhter · 2024-01-23T11:45:17Z

@gardar If you could push a merge request with the first three commits (without "fix role name"), I'd merge that right away. Those three commits are not really isolated so they can be squashed together.
The commit "fix role name" needs some attention because we don't wanna mess again the Ansible galaxy, this is why I'd separate that single commit.

gardar · 2024-01-23T11:48:20Z

ansible-lint refuses to run without fixing the role name first.
With that being said I'm still working on this, so it's not ready for merge just yet.

guenhter · 2024-01-23T11:56:01Z

I missed the draft status. Thx

Signed-off-by: gardar <[email protected]>

gardar · 2024-01-23T16:22:22Z

All issues fixed, are you sure about reverting the role name from gitlab_runner to gitlab-runner?

riemers · 2024-01-23T16:26:29Z

It should be as it is in ansible galaxy right now. Since that one has all the history.

…

________________________________ Van: gardar ***@***.***> Verzonden: Tuesday, January 23, 2024 5:22:32 PM Aan: riemers/ansible-gitlab-runner ***@***.***> CC: Erik-jan Riemers ***@***.***>; Mention ***@***.***> Onderwerp: Re: [riemers/ansible-gitlab-runner] Fix linting issues (PR #312) All issues fixed, are you sure about reverting the role name<https://ansible.readthedocs.io/projects/lint/rules/role-name/> from gitlab_runner to gitlab-runner? — Reply to this email directly, view it on GitHub<#312 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAFGQOKGPJ3W4LMFPHUXGSLYP7PURAVCNFSM6AAAAABCGZ747WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBWGQZDIMBSHA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

gardar · 2024-01-23T16:40:16Z

I see, the transition from hyphens to underscore in galaxy was some time ago and I think you can't make new roles with hyphens in the name.
Perhaps it's possible to get an alias in galaxy? So that both gitlab-runner and gitlab_runner names work?

riemers · 2024-01-25T06:50:42Z

Don’t dare to touch it.. but I can ask if an alias is possible. But if it is that means people can steal other names too. So I doubt it. Going back and forth also doesn’t help ;)

…

________________________________ Van: gardar ***@***.***> Verzonden: Tuesday, January 23, 2024 5:40:27 PM Aan: riemers/ansible-gitlab-runner ***@***.***> CC: Erik-jan Riemers ***@***.***>; Mention ***@***.***> Onderwerp: Re: [riemers/ansible-gitlab-runner] Fix linting issues (PR #312) I see, the transition from hyphens to underscore in galaxy was some time ago and I think you can't make new roles with hyphens in the name. Perhaps it's possible to get an alias in galaxy? So that both gitlab-runner and gitlab_runner names work? — Reply to this email directly, view it on GitHub<#312 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAFGQOMTGV2QPKO4GUPITTDYP7RXXAVCNFSM6AAAAABCGZ747WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBWGQ3TEMJYGA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

gardar · 2024-01-25T13:51:52Z

Well since role names are now required to be with underscores and hyphens are only allowed for legacy purposes one would assume an alias would be standard practice.
I don't think anyone is able to steal your role name since it's prefixed with your namespace 😃

Let me know if you want to check with the galaxy team or I can change the metadata and add the role name linting rule to the ignore list.

riemers · 2024-01-25T18:44:26Z

If it is possible to have both that would be fine too. I know a lot of people used the old role.. but it won’t be end of the world either.

…

________________________________ Van: gardar ***@***.***> Verzonden: Thursday, January 25, 2024 2:52:02 PM Aan: riemers/ansible-gitlab-runner ***@***.***> CC: Erik-jan Riemers ***@***.***>; Mention ***@***.***> Onderwerp: Re: [riemers/ansible-gitlab-runner] Fix linting issues (PR #312) Well since role names are now required to be with underscores and hyphens are only allowed for legacy purposes one would assume an alias would be standard practice. I don't think anyone is able to steal your role name since it's prefixed with your namespace 😃 Let me know if you want to check with the galaxy team or I can change the metadata and add the role name linting rule to the ignore list. — Reply to this email directly, view it on GitHub<#312 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAFGQOL5RSO4SLIPNGNWDDLYQJPQFAVCNFSM6AAAAABCGZ747WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJQGI3DCMJZGA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

gardar · 2024-01-25T19:42:35Z

Ok let me know if you get any response from the inquiry, otherwise I'll change the meta.

ericsysmin · 2024-02-12T18:56:05Z

All issues fixed, are you sure about reverting the role name from gitlab_runner to gitlab-runner?

In newer Ansible versions gitlab-runner throws errors, using _ in the role name is basically a requirement. Using the role_name value in meta helps address this without changing repository name. I believe Galaxy if I remember correctly now will reject it if there's a - in the name.

riemers · 2024-02-13T08:46:43Z

Maybe we can do both? I mean if it’s a requirement somewhere on the website and we should follow that pattern but then I loose the history / downloads from it too no?

…

________________________________ Van: Eric Anderson ***@***.***> Verzonden: Monday, February 12, 2024 7:56:17 PM Aan: riemers/ansible-gitlab-runner ***@***.***> CC: Erik-jan Riemers ***@***.***>; Mention ***@***.***> Onderwerp: Re: [riemers/ansible-gitlab-runner] Fix linting issues (PR #312) All issues fixed, are you sure about reverting the role name<https://ansible.readthedocs.io/projects/lint/rules/role-name/> from gitlab_runner to gitlab-runner? In newer Ansible versions gitlab-runner throws errors, using _ in the role name is basically a requirement. Using the role_name value in meta helps address this without changing repository name. — Reply to this email directly, view it on GitHub<#312 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAFGQOPVKIITE37XCZFC7XLYTJQVDAVCNFSM6AAAAABCGZ747WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZZGM2DMNBZGI>. You are receiving this because you were mentioned.Message ID: ***@***.***>

gardar · 2024-02-13T12:37:26Z

I see two options, either to get the role renamed to gitlab_runner on galaxy, or if possible to add a alias on galaxy so that the role is available under both names.

gardar · 2024-02-27T16:02:27Z

So what's the situation here, have you checked if the role can be renamed or if you can get a name alias?

riemers · 2024-02-27T18:38:32Z

Been I’ll for some time and also busy as you are also ;) still have to do boring taxes and playing helpdesk for the family’s. I’ll need some time in the weekend and take some time for it.

…

________________________________ Van: gardar ***@***.***> Verzonden: Tuesday, February 27, 2024 5:02:40 PM Aan: riemers/ansible-gitlab-runner ***@***.***> CC: Erik-jan Riemers ***@***.***>; Mention ***@***.***> Onderwerp: Re: [riemers/ansible-gitlab-runner] Fix linting issues (PR #312) So what's the situation here, have you checked if the role can be renamed or if you can get a name alias? — Reply to this email directly, view it on GitHub<#312 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAFGQOJNKZRWCKEWG7VMTPLYVX7SBAVCNFSM6AAAAABCGZ747WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRWHA4TKMRXGI>. You are receiving this because you were mentioned.Message ID: ***@***.***>

github-actions · 2024-04-13T01:40:24Z

Although PRs are appreciated, if it sits for too long nothing happens. Can always update and do again :) This is just the automation talking

gardar · 2024-04-13T02:43:38Z

Any news @riemers ?

guenhter · 2024-04-25T09:35:52Z

@gardar If you would split this PR to have only linting changes and not metadata changes like the role_name, I'll be happy to merge it right away. If you keep it as is, I don't want to touch it because we had troubles with Ansible-Galaxy before and this is too hot for me.

Signed-off-by: gardar <[email protected]>

guenhter · 2024-04-25T13:54:07Z

handlers/main.yml

@@ -13,6 +13,7 @@
  ansible.builtin.command: "{{ gitlab_runner_executable }} restart"
  listen: restart_gitlab_runner_macos
  become: "{{ gitlab_runner_system_mode }}"
+  changed_when: true


I this necessary? Doesn't the command module produces a "changed" anyway?

guenhter · 2024-04-25T14:20:42Z

Could you please do a rebase onto master to get rid if the merge commit, because it seems when resolving the problems within the merge, some lines got lost (of a previous MR). To be on the safe side, please rebase then I'll review it again.

Signed-off-by: gardar <[email protected]>

guenhter · 2024-04-26T09:42:54Z

And let me know when you are done, then I'll have another look at it

guenhter · 2024-05-07T08:32:24Z

@gardar when the conflicts are resolved and the branch is rebased, I'm happy to merge

gardar · 2024-05-08T10:41:44Z

Thanks! Haven't had time to complete it yet, I'll give you a ping once it's ready.

github-actions · 2024-06-23T01:51:45Z

Although PRs are appreciated, if it sits for too long nothing happens. Can always update and do again :) This is just the automation talking

gardar · 2024-06-23T02:05:09Z

Unstale

github-actions · 2024-08-08T01:52:50Z

Although PRs are appreciated, if it sits for too long nothing happens. Can always update and do again :) This is just the automation talking

riemers · 2024-08-08T09:40:39Z

Unstale i suppose ;p

Stunkymonkey · 2024-08-12T20:22:47Z

requirements.yml

maybe we should close #342. the linting would already "fix" it. but not with optional dependencies.

riemers · 2024-08-13T12:13:28Z

See #344

gardar added 6 commits January 23, 2024 11:17

fix: role name

b9add3c

Signed-off-by: gardar <[email protected]>

fix: use fqcn

c71e259

Signed-off-by: gardar <[email protected]>

fix: add ansible.windows collection requirement

aec834e

Signed-off-by: gardar <[email protected]>

fix: add community.docker collection requirement

e3024b6

Signed-off-by: gardar <[email protected]>

fix: use command module instead of shell where possible

ee84328

Signed-off-by: gardar <[email protected]>

fix: name casting

814968e

Signed-off-by: gardar <[email protected]>

guenhter reviewed Jan 23, 2024

View reviewed changes

meta/main.yml Outdated Show resolved Hide resolved

fix: no-free-form

d1ba5c2

Signed-off-by: gardar <[email protected]>

gardar added 6 commits January 23, 2024 12:29

fix: key order

272cc8b

Signed-off-by: gardar <[email protected]>

fix: task names

d948304

Signed-off-by: gardar <[email protected]>

fix: file permissions

65815cb

Signed-off-by: gardar <[email protected]>

fix: changed_when

1c2535e

Signed-off-by: gardar <[email protected]>

fix: jinja2 formatting

557fc01

Signed-off-by: gardar <[email protected]>

fix: yaml linting

f5b17e9

Signed-off-by: gardar <[email protected]>

gardar marked this pull request as ready for review January 23, 2024 16:21

github-actions bot added the Stale label Apr 13, 2024

github-actions bot removed the Stale label Apr 14, 2024

gardar added 2 commits April 25, 2024 12:55

Merge branch 'master' into lint

0ae03b0

fix: lint rebase

dd19793

Signed-off-by: gardar <[email protected]>

gardar force-pushed the lint branch 2 times, most recently from 2f3b053 to 534541e Compare April 25, 2024 13:28

guenhter reviewed Apr 25, 2024

View reviewed changes

gardar force-pushed the lint branch 2 times, most recently from f92d0b7 to 7f47d30 Compare April 25, 2024 22:37

fix: make invalid role-name pass linter as requested

8a169d5

Signed-off-by: gardar <[email protected]>

gardar force-pushed the lint branch from 7f47d30 to 8a169d5 Compare April 25, 2024 22:58

github-actions bot added the Stale label Jun 23, 2024

github-actions bot removed the Stale label Jun 24, 2024

github-actions bot added the Stale label Aug 8, 2024

riemers removed the Stale label Aug 8, 2024

Stunkymonkey reviewed Aug 12, 2024

View reviewed changes

requirements.yml

Copy link

Contributor

Stunkymonkey Aug 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should close #342. the linting would already "fix" it. but not with optional dependencies.

Stunkymonkey mentioned this pull request Aug 12, 2024

fix linter #344

Merged

riemers closed this Aug 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix linting issues #312

Fix linting issues #312

gardar commented Jan 23, 2024 •

edited

Loading

guenhter commented Jan 23, 2024

gardar commented Jan 23, 2024

guenhter commented Jan 23, 2024

gardar commented Jan 23, 2024

riemers commented Jan 23, 2024 via email

gardar commented Jan 23, 2024

riemers commented Jan 25, 2024 via email

gardar commented Jan 25, 2024

riemers commented Jan 25, 2024 via email

gardar commented Jan 25, 2024

ericsysmin commented Feb 12, 2024 •

edited

Loading

riemers commented Feb 13, 2024 via email

gardar commented Feb 13, 2024

gardar commented Feb 27, 2024

riemers commented Feb 27, 2024 via email

github-actions bot commented Apr 13, 2024

gardar commented Apr 13, 2024

guenhter commented Apr 25, 2024

guenhter Apr 25, 2024 •

edited

Loading

guenhter commented Apr 25, 2024

guenhter commented Apr 26, 2024

guenhter commented May 7, 2024

gardar commented May 8, 2024

github-actions bot commented Jun 23, 2024

gardar commented Jun 23, 2024

github-actions bot commented Aug 8, 2024

riemers commented Aug 8, 2024

Stunkymonkey Aug 12, 2024

riemers commented Aug 13, 2024

Fix linting issues #312

Fix linting issues #312

Conversation

gardar commented Jan 23, 2024 • edited Loading

guenhter commented Jan 23, 2024

gardar commented Jan 23, 2024

guenhter commented Jan 23, 2024

gardar commented Jan 23, 2024

riemers commented Jan 23, 2024 via email

gardar commented Jan 23, 2024

riemers commented Jan 25, 2024 via email

gardar commented Jan 25, 2024

riemers commented Jan 25, 2024 via email

gardar commented Jan 25, 2024

ericsysmin commented Feb 12, 2024 • edited Loading

riemers commented Feb 13, 2024 via email

gardar commented Feb 13, 2024

gardar commented Feb 27, 2024

riemers commented Feb 27, 2024 via email

github-actions bot commented Apr 13, 2024

gardar commented Apr 13, 2024

guenhter commented Apr 25, 2024

guenhter Apr 25, 2024 • edited Loading

Choose a reason for hiding this comment

guenhter commented Apr 25, 2024

guenhter commented Apr 26, 2024

guenhter commented May 7, 2024

gardar commented May 8, 2024

github-actions bot commented Jun 23, 2024

gardar commented Jun 23, 2024

github-actions bot commented Aug 8, 2024

riemers commented Aug 8, 2024

Stunkymonkey Aug 12, 2024

Choose a reason for hiding this comment

riemers commented Aug 13, 2024

gardar commented Jan 23, 2024 •

edited

Loading

ericsysmin commented Feb 12, 2024 •

edited

Loading

guenhter Apr 25, 2024 •

edited

Loading