Fix riemann-wrapper with older Ruby
#290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b4254bd. The YAML.safe_load_file function was added in Psych 3.2.1, but only Ruby 3 and newer provide this version of the Psych library. Since this gem is supposed to work with older (EOL) Ruby versions, revert this for now. At some point we will drop support for EOL Ruby, but it will be a backwards incompatbile change and there is no hurry for that at the moment, and some supported Linux distro still ship these legacy Ruby versions.
smortex
added
bug
|
When this was introduced in #285, the rubocop configuration was probably messed-up and not targeting the version or Ruby from the .gemspec file. This has never been released, so also label the issue as skip-changelog because this fix is not something that will be visible to end-users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b4254bd.
The YAML.safe_load_file function was added in Psych 3.2.1, but only Ruby
3 and newer provide this version of the Psych library. Since this gem
is supposed to work with older (EOL) Ruby versions, revert this for now.
At some point we will drop support for EOL Ruby, but it will be a
backwards incompatbile change and there is no hurry for that at the
moment, and some supported Linux distro still ship these legacy Ruby
versions.