-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edns pass config to system #6102
Draft
rvykydal
wants to merge
2
commits into
rhinstaller:main
Choose a base branch
from
rvykydal:edns-pass-config-to-system
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvykydal
temporarily deployed
to
gh-cockpituous
January 21, 2025 14:18 — with
GitHub Actions
Inactive
Hello @rvykydal! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2025-01-22 15:31:51 UTC |
/kickstart-test --testtype smoke |
We should preserve also |
rvykydal
force-pushed
the
edns-pass-config-to-system
branch
from
January 22, 2025 15:28
550370b
to
a8df73f
Compare
rvykydal
temporarily deployed
to
gh-cockpituous
January 22, 2025 15:28 — with
GitHub Actions
Inactive
Resolves: INSTALLER-4097
Resolves: INSTALLER-4097
rvykydal
force-pushed
the
edns-pass-config-to-system
branch
from
January 22, 2025 15:31
a8df73f
to
2eae972
Compare
rvykydal
temporarily deployed
to
gh-cockpituous
January 22, 2025 15:31 — with
GitHub Actions
Inactive
Kickstart test: rhinstaller/kickstart-tests#1361 |
/kickstart-test --testtype smoke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: