Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data: profile: extend workstation profile to hide pages for Web UI #6047

Merged
merged 2 commits into from
Jan 14, 2025
Merged

data: profile: extend workstation profile to hide pages for Web UI #6047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
868f521
data: profile: extend workstation profile to hide pages for Web UI
KKoukiou Dec 13, 2024
9b54f34
docs: add release note for the `hidden-webui-pages` configuration option
KKoukiou Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion data/anaconda.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,10 +284,14 @@ reformat_blocklist = /home /usr/local /opt /var/www
# The path to a custom stylesheet.
custom_stylesheet =

# A list of spokes to hide in UI.
# A list of spokes to hide in GTK UI.
# FIXME: Use other identification then names of the spokes.
hidden_spokes =

# A list of spokes to hide in Web UI.
# Use the ID attribute of the Page class.
hidden_webui_pages =

# Should the UI allow to change the configured root account?
can_change_root = False

Expand Down
3 changes: 3 additions & 0 deletions data/profile.d/fedora-workstation.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ hidden_spokes =
NetworkSpoke
PasswordSpoke
UserSpoke
hidden_webui_pages =
anaconda-screen-accounts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the prefix? Will it be a situation when it is not anaconda-screen prefix?

If yes, could you please document it somewhere (commit message for example)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been discussed more in the web UI PR rhinstaller/anaconda-webui#551 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, ok.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still like to see the reasoning as part of the commit if possible.

anaconda-screen-language

[Localization]
# disable localization for the Fedora Workstation live image to avoid
Expand Down
18 changes: 18 additions & 0 deletions docs/release-notes/hidden-webui-pages.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
:Type: Configuration
:Summary: Support for Hiding Specific Pages in the Web UI

:Description:
The Web UI now supports hiding specific pages by adding their page IDs to the
hidden-webui-pages option in the anaconda.conf file.

For example, in the Workstation ISO, the 'Account Creation' page shoult not be displayed,
as this step is handled by GNOME Initial Setup during first boot. To hide this page,
the following configuration is be added:

hidden-webui-pages = anaconda-screen-accounts

This feature allows tailoring the Web UI experience to meet the specific needs of
different ISOs or spins.

:Links:
- https://github.com/rhinstaller/anaconda/pull/6047
Loading