Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHEL-9] Use recommended format for JIRA links #5364

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

jkonecny12
Copy link
Member

Use recommended format for JIRA links and improve output logs to make them less confusing.

I found recommendation on JIRA link format so change our makebumpver
script accordingly to this recommendation.
Old output might be confusing to people so let's switch from:

*** Bug RHEL-11111 Related commit 18b88f233a0195a56805f6e268a269cc11e4f4b3 is allowed
*** Bug RHEL-22222 Resolves commit 18b88f233a0195a56805f6e268a269cc11e4f4b3 is allowed

to:

*** Reverts RHEL-11111 commit 18b88f233a0195a56805f6e268a269cc11e4f4b3 is allowed
*** Resolves RHEL-22222 commit 18b88f233a0195a56805f6e268a269cc11e4f4b3 is allowed
@jkonecny12 jkonecny12 added infrastructure Changes affecting mostly infrastructure rhel-9 labels Dec 7, 2023
Copy link
Contributor

@jstodola jstodola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. What I've just realized is that the guidelines in docs/commit-log.rst should also be updated to use the new Jira format.

@jkonecny12
Copy link
Member Author

Good point. Changed and also creating a new PR for removing outdated scripts.

docs/commit-log.rst Outdated Show resolved Hide resolved
docs/commit-log.rst Outdated Show resolved Hide resolved
There are some changes to the workflow:
- We don't support links in summary lines anymore
- Conflicts is not supported anymore
- Reverts is new supported action
@jkonecny12 jkonecny12 force-pushed the rhel-9-change-RHEL-link branch from 5b80544 to cf43cfb Compare December 8, 2023 13:20
Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well. :)

@jkonecny12
Copy link
Member Author

/kickstart-test --waive infra only

@jkonecny12 jkonecny12 merged commit 9ee6eb4 into rhinstaller:rhel-9 Dec 11, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Changes affecting mostly infrastructure rhel-9
Development

Successfully merging this pull request may close these issues.

3 participants