-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHEL-9] Use recommended format for JIRA links #5364
[RHEL-9] Use recommended format for JIRA links #5364
Conversation
I found recommendation on JIRA link format so change our makebumpver script accordingly to this recommendation.
Old output might be confusing to people so let's switch from: *** Bug RHEL-11111 Related commit 18b88f233a0195a56805f6e268a269cc11e4f4b3 is allowed *** Bug RHEL-22222 Resolves commit 18b88f233a0195a56805f6e268a269cc11e4f4b3 is allowed to: *** Reverts RHEL-11111 commit 18b88f233a0195a56805f6e268a269cc11e4f4b3 is allowed *** Resolves RHEL-22222 commit 18b88f233a0195a56805f6e268a269cc11e4f4b3 is allowed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me. What I've just realized is that the guidelines in docs/commit-log.rst should also be updated to use the new Jira format.
Good point. Changed and also creating a new PR for removing outdated scripts. |
There are some changes to the workflow: - We don't support links in summary lines anymore - Conflicts is not supported anymore - Reverts is new supported action
5b80544
to
cf43cfb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as well. :)
/kickstart-test --waive infra only |
Use recommended format for JIRA links and improve output logs to make them less confusing.