tests: report passed testcases to Fedora Wiki #601
+167
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKoukiou
force-pushed
the
INSTALLER-4111
branch
3 times, most recently
from
083c3f8 to
30ec03a
Compare
KKoukiou
force-pushed
the
INSTALLER-4111
branch
from
30ec03a to
22beae8
Compare
KKoukiou
changed the title
KKoukiou
added a commit
to KKoukiou/cockpituous
that referenced
this pull request
Jan 23, 2025
KKoukiou
force-pushed
the
INSTALLER-4111
branch
from
22beae8 to
54ae12b
Compare
KKoukiou
added a commit
to KKoukiou/cockpituous
that referenced
this pull request
Jan 23, 2025
martinpitt
pushed a commit
to cockpit-project/cockpituous
that referenced
this pull request
Jan 23, 2025
The section is needed when reporting the tests results to the Wiki. Wiki still does not contains Web UI specific tests plans in the Matrix. The sections specified in this commit are not yet present either.
KKoukiou
force-pushed
the
INSTALLER-4111
branch
2 times, most recently
from
6bae4cc to
e809bdc
Compare
jkonecny12
approved these changes
Jan 23, 2025
| dist="Fedora", | ||
| env=testcase["env"], | ||
| milestone="Rawhide", | ||
| release="42", |
There was a problem hiding this comment.
Please put the TODO from commit message to the code. It is more visible.
| try: | ||
| wiki.login() | ||
| except mwclient.errors.LoginError: | ||
| wiki.login() |
There was a problem hiding this comment.
Shouldn't we put at least a small sleep before the second attempt?
Also we should log why was the login unsuccessful if possible.
There was a problem hiding this comment.
Hm, not sure how it would help, we are guessing at this point. Anyway, I copied this code from https://pagure.io/fedora-qa/fedora_openqa/blob/main/f/src/fedora_openqa/report.py#_338
Comment on lines
+92
to
+94
| tmpl = "already reported result for test %s, env %s! Will not report dupe." | ||
| logger.info(tmpl, dupe.testcase, dupe.env) |
There was a problem hiding this comment.
I don't think that tmpl variable is necessary, just write the message on two lines or create a new line before.
Just a suggestion, I don't insist on fixing this.
There was a problem hiding this comment.
it would be long line
| logger.debug("full ResTuple: %s", dupe) | ||
|
|
||
| for insuff in insuffs: | ||
| tmpl = "insufficient data for test %s, env %s! Will not report." |
Only when testing against composes. This was inspired by openQA Wiki report script [1]. TODO: Remove 'Fedora 42' hardcoded values. [1] https://pagure.io/fedora-qa/fedora_openqa/blob/main/f/src/fedora_openqa/report.py
KKoukiou
force-pushed
the
INSTALLER-4111
branch
from
e809bdc to
939dd71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.