Fix sleep workaround with Xorg #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstodola
reviewed
Nov 19, 2024
etc/systemd/system/anabot.service
Outdated
| @@ -12,7 +12,7 @@ ConditionArchitecture=!s390x | |||
| # It seems the delay shouldn't be needed with Wayland (and/or with the new version | |||
| # of dogtail). If it turns out it's not the case, we should remove the sleep | |||
| # from here and implement it it launcher.py. | |||
| ExecStartPre=sh -c "ps aux | grep -q gnome-kiosk || sleep 30" | |||
| ExecStartPre=sh -c "ps aux | grep -q Xorg && sleep 30" | |||
There was a problem hiding this comment.
Actually, this might still be problematic, for example when an application is executed with a possible --no-Xorg argument.
What about using which Xorg instead of listing running processes?
There was a problem hiding this comment.
Thanks for having a look, that's actually a good point. Fixed.
I didn't realize gnome-kiosk is actually used even with Xorg, so the sleep workaround wouldn't actually apply at all. Grepping for Xorg instead should be bulletproof.
jikortus
force-pushed
the
xorg-sleep-workaround-fix
branch
from
3a9b0a9 to
062cff6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't realize gnome-kiosk is actually used even with Xorg, so the sleep workaround wouldn't actually apply at all. Grepping for Xorg instead should be bulletproof.