-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR workflow fixes #54
Conversation
107f77c
to
437e3de
Compare
podman kill anabot | ||
podman image rm quay.io/centos/centos:stream9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't this be done simply by podman image rm --force ...
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it should work the same, I think. I may try to resort to the force deletion, but I wonder why the image still doesn't get deleted by the current solution, despite it not being used by any container (as you can see in the workflow script output). @velezd, you know most likely much more about the GitHub workflows - is it possible that this is a 'feature' for some reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jstodola so I tried to just enforce the image removal as you suggested and it works fine (as you can see in the checks below). However, just FYI, I think that even if we didn't do any cleanup at all, it shouldn't actually cause any mess, because the workflows use a fresh VM every time, which makes sense after all:
Each workflow run executes in a fresh, newly-provisioned virtual machine.
437e3de
to
7f64ce0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. We can remove the cleanup part if it keeps causing issues in the future.
Thanks for the review! |
lanabot/runtime/installation/hub/keyboard/layouts.py
, it seems better to add them instead of ignore the import errors in pylint)