Fix loop over dict in raid_name() #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original approch shouldn't actually break anything, but pylint was unhappy about it for a reason.
jstodola
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original approch shouldn't actually break anything, but pylint was unhappy about it for a reason:
anabot/runtime/installation/hub/partitioning/advanced/common.py:46:12: E4702: Iterated dict 'LEVELS' is being modified inside for loop body, iterate through a copy of it instead. (modified-iterating-dict)This pylint error was actually discovered as part of work on PR #53; this PR (#52) should likely be merged after 53, so that all of the checks pass.