-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use notifications specs from github repo #55
Conversation
@rgolangh in the MTA props, I do not see where you set the URL for the notification, is it missing? |
/hold Do not merge until notification plugin is made a dynamic plugin: the PR uses the specs from release 1.0.3 (https://github.com/janus-idp/backstage-plugins/releases/tag/%40janus-idp%2Fplugin-notifications-backend%401.0.3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@gabriel-farache pls rebase. (or wait for few more days and then rebase :-) ) |
43ee62d
to
6b8a36e
Compare
I think there's was a url in the openapi spec |
So I still think we need a property for MTA for notification endpoint , because the default in the openapi spec |
we would need to add , for e2e , an env variable to point at the e2e endpoint, similar to |
6b8a36e
to
c1e5cb2
Compare
@rgolangh done :) |
/unhold |
apache/incubator-kie-kogito-runtimes#3377 is merged so sonataflow should have the openapi generator version that includes the fix in tomorrow's nightly And rhdhorchestrator/orchestrator-helm-chart#45 is including the notification plugin as a dynamic one in the charts |
@gabriel-farache some of the changes were pushed in a previously merged PR. Please rebase. |
1d548e5
to
2461737
Compare
@masayag done |
Use notifications specs from github repo to avoid duplicate files in each workflow specs