Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use private kn-workflow for gen-manifests #335

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Conversation

rgolangh
Copy link
Collaborator

Signed-off-by: Roy Golan [email protected]

@rgolangh
Copy link
Collaborator Author

/hold
I think I see a problem with the created manifests.

@rgolangh
Copy link
Collaborator Author

mm the name of the manifest of the workflow file is now 03-sonataflow_mtaanalysis.yaml. And not 01...
We would have to 1. remove the existing manifests (just once) 2. change gen-manifest script to look for *-sonataflow_$workflow_id.yaml

@masayag
Copy link
Collaborator

masayag commented Jul 23, 2024

mm the name of the manifest of the workflow file is now 03-sonataflow_mtaanalysis.yaml. And not 01... We would have to 1. remove the existing manifests (just once) 2. change gen-manifest script to look for *-sonataflow_$workflow_id.yaml

Would you prefer to include the changes before submitting this PR or as part of it?

@rgolangh rgolangh force-pushed the use-private-kn-workflow branch from 64d19e3 to 3c2efbf Compare July 24, 2024 10:30
@masayag
Copy link
Collaborator

masayag commented Jul 25, 2024

Let's merge this on Sunday :-)
But before that, shellcheck complains:

In scripts/gen_manifests.sh line 50:
SONATAFLOW_CR="$(printf '%s' manifests/*-sonataflow_${workflow_id}.yaml)"
                                                    ^------------^ SC208[6](https://github.com/parodos-dev/serverless-workflows/actions/runs/10075226922/job/27853023783?pr=335#step:4:7) (info): Double quote to prevent globbing and word splitting.

@rgolangh
Copy link
Collaborator Author

Let's merge this on Sunday :-) But before that, shellcheck complains:

In scripts/gen_manifests.sh line 50:
SONATAFLOW_CR="$(printf '%s' manifests/*-sonataflow_${workflow_id}.yaml)"
                                                    ^------------^ SC208[6](https://github.com/parodos-dev/serverless-workflows/actions/runs/10075226922/job/27853023783?pr=335#step:4:7) (info): Double quote to prevent globbing and word splitting.

why wait? we need every bit to help :)
I saw the shellcheck error, will fix

@rgolangh rgolangh force-pushed the use-private-kn-workflow branch from e88e505 to 18c9cff Compare July 25, 2024 12:41
@rgolangh rgolangh force-pushed the use-private-kn-workflow branch 4 times, most recently from 534c1b8 to ab652ff Compare July 29, 2024 16:50
@masayag
Copy link
Collaborator

masayag commented Jul 29, 2024

@rgolangh do the call to m2k might also need a token which is missed?

++ curl -XGET -s -o /dev/null -w '%{http_code}' http://localhost:9080/api/orchestrator/workflows/m2k
Handling connection for 9080
+ M2K_STATUS=401

- revert the fake notification after the orchestrator-k8s chart is
  functional with rhdh 1.2 with notification plugin
- use the backend secret value to configure the workflow
- use the backend secret value to perform call from e2e tests

Signed-off-by: Roy Golan <[email protected]>
@rgolangh rgolangh force-pushed the use-private-kn-workflow branch from ab652ff to 06e435d Compare July 29, 2024 17:17
@masayag
Copy link
Collaborator

masayag commented Jul 29, 2024

@rgolangh going to merge this as-is since the only remaining changes are around adding authorization header to other MTA calls.

@masayag masayag merged commit 67f7430 into main Jul 29, 2024
5 of 6 checks passed
orchestrator-ci pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Jul 29, 2024
@rgolangh
Copy link
Collaborator Author

@rgolangh do the call to m2k might also need a token which is missed?

++ curl -XGET -s -o /dev/null -w '%{http_code}' http://localhost:9080/api/orchestrator/workflows/m2k
Handling connection for 9080
+ M2K_STATUS=401

was fixed with latest push

orchestrator-ci pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Jul 29, 2024
orchestrator-ci pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Jul 29, 2024
orchestrator-ci pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Jul 29, 2024
masayag pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Jul 30, 2024
masayag pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Jul 30, 2024
masayag pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Jul 30, 2024
masayag pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Jul 30, 2024
masayag pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Jul 30, 2024
masayag pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Jul 30, 2024
@masayag masayag deleted the use-private-kn-workflow branch July 31, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants