-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use private kn-workflow for gen-manifests #335
Conversation
/hold |
mm the name of the manifest of the workflow file is now 03-sonataflow_mtaanalysis.yaml. And not 01... |
Would you prefer to include the changes before submitting this PR or as part of it? |
64d19e3
to
3c2efbf
Compare
Let's merge this on Sunday :-)
|
why wait? we need every bit to help :) |
e88e505
to
18c9cff
Compare
Signed-off-by: Roy Golan <[email protected]>
Signed-off-by: Roy Golan <[email protected]>
Signed-off-by: Roy Golan <[email protected]>
534c1b8
to
ab652ff
Compare
@rgolangh do the call to m2k might also need a token which is missed?
|
- revert the fake notification after the orchestrator-k8s chart is functional with rhdh 1.2 with notification plugin - use the backend secret value to configure the workflow - use the backend secret value to perform call from e2e tests Signed-off-by: Roy Golan <[email protected]>
ab652ff
to
06e435d
Compare
@rgolangh going to merge this as-is since the only remaining changes are around adding authorization header to other MTA calls. |
was fixed with latest push |
Signed-off-by: Roy Golan [email protected]