flpath751 - Add MTA v6.2.2 and MTA v7.0.2 #198
Conversation
e2e/mtav6.2.2.sh
Outdated
There was a problem hiding this comment.
the three files e2e/mtaXYZ.sh are exactly the same, can't you just use one and refer to it in the GH action?
There was a problem hiding this comment.
Things are wip, please see my latest comment.
I agree. I guess once the v6.2.2 and v7.0.2 are in, we can safely remove the original MTA directory. |
| # Use a fixed folder to simplify limactl configuration (must be mounted with Write permissions) | ||
| WORKDIR := /tmp/serverless-workflows | ||
| endif | ||
| WORKDIR := ~/workdir |
There was a problem hiding this comment.
are you sure this works when it's launched from a GH action, have you tested this use case? (e.g., "escalation" workflows are built this way)
| @@ -166,13 +165,4 @@ gen-manifests: prepare-workdir | |||
| cd $(WORKDIR) | |||
| @$(CONTAINER_ENGINE) run --rm -v $(WORKDIR):/workdir -w /workdir \ | |||
| $(LINUX_IMAGE) /bin/bash -c "${SCRIPTS_DIR}/gen_manifests.sh $(WORKFLOW_ID) $(ENABLE_PERSISTENCE)" | |||
| @echo "Manifests are available in workdir $(WORKDIR)/$(WORKFLOW_ID)/manifests" | |||
|
|
|||
| # Target: push-manifests | |||
There was a problem hiding this comment.
any reasons for removing this target?
as I said before, "escalation" is built with the Makefile and manifests pushed with this target
There was a problem hiding this comment.
Things are wip, please see my latest comment.
| quarkus.kogito.devservices.enabled=false | ||
|
|
||
| mta.url = ${MTA_URL:http://mta-ui.openshift-mta.svc.cluster.local:8080} | ||
| quarkus.rest-client.mta_json.url = ${mta.url} |
There was a problem hiding this comment.
if you look at the original file in mta folder, it is:
${mta.url}/hub
There was a problem hiding this comment.
There was a problem hiding this comment.
Then I give up, surely @gabriel-farache knows it
|
Hi @dmartinol Thanks for review comments. I am working on making local testing of workflows ( please see directory experimental-ci-on-vm) on local clusters work first. I think I will switch this PR to draft or close for now and raise a new one. |
|
Closing this for now as needs local tests and to avoid GH Actions pipeline triggers for every commit. |
Hi @dmartinol / @masayag / @pkliczewski,
Please review and merge or provide feedback for changes.
This is part 1 of instructions steps 1-4 at https://github.com/parodos-dev/serverless-workflows/tree/main?tab=readme-ov-file#to-introduce-a-new-workflow.
For part 2 with steps 5-7, I will raise a separate PR towards serverless-workflows-config repo.
Thanks.