Ignore expression CC

rhargreaves · Jun 30, 2024 · 226ada1 · 226ada1
1 parent 764b29e
commit 226ada1
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 0 deletions.
diff --git a/src/midi.c b/src/midi.c
@@ -803,6 +803,7 @@ static void setFmChanParameter(DeviceChannel* devChan, u8 controller, u8 value)
             break;
         synth_stereo(devChan->number, RANGE(value, 4));
         break;
+    case CC_EXPRESSION:
     case CC_SUSTAIN_PEDAL:
     case CC_DATA_ENTRY_LSB:
     case CC_DATA_ENTRY_MSB:

diff --git a/src/midi.h b/src/midi.h
@@ -33,6 +33,7 @@
 #define CC_DATA_ENTRY_MSB 6
 #define CC_VOLUME 7
 #define CC_PAN 10
+#define CC_EXPRESSION 11
 #define CC_GENMDM_FM_ALGORITHM 14
 #define CC_GENMDM_FM_FEEDBACK 15
 #define CC_GENMDM_TOTAL_LEVEL_OP1 16

diff --git a/tests/unit/main.c b/tests/unit/main.c
@@ -134,6 +134,7 @@ int main(void)
         midi_test(test_midi_unsets_polyphonic_mode),
         midi_test(test_midi_sets_unknown_CC),
         midi_test(test_midi_ignores_sustain_pedal_cc),
+        midi_test(test_midi_ignores_expression_cc),
         midi_test(test_midi_ignores_sysex_nrpn_ccs),
         midi_test(test_midi_polyphonic_mode_sends_CCs_to_all_FM_channels),
         midi_test(test_midi_set_overflow_flag_on_polyphony_breach),

diff --git a/tests/unit/test_midi.c b/tests/unit/test_midi.c
@@ -116,6 +116,15 @@ void test_midi_ignores_sustain_pedal_cc(UNUSED void** state)
     __real_midi_cc(0, cc, 1);
 }
 
+void test_midi_ignores_expression_cc(UNUSED void** state)
+{
+    wraps_enable_logging_checks();
+
+    u8 cc = 11;
+
+    __real_midi_cc(0, cc, 1);
+}
+
 void test_midi_ignores_sysex_nrpn_ccs(UNUSED void** state)
 {
     wraps_enable_logging_checks();

diff --git a/tests/unit/test_midi.h b/tests/unit/test_midi.h
@@ -51,3 +51,4 @@ void test_midi_resets_fm_values_to_defaults(UNUSED void** state);
 void test_midi_resets_psg_values_to_defaults(UNUSED void** state);
 void test_midi_ignores_sustain_pedal_cc(UNUSED void** state);
 void test_midi_ignores_sysex_nrpn_ccs(UNUSED void** state);
+void test_midi_ignores_expression_cc(UNUSED void** state);