Avoid string concatenation with Runtime.getRuntime().exec(..).

- Also remove foo.xml Signed-off-by: Roland Grunberg <[email protected]>
rgrunber · Jan 12, 2024 · bfafff4 · bfafff4
1 parent c971205
commit bfafff4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/org.eclipse.jdt.ls.core/foo.xml b/org.eclipse.jdt.ls.core/foo.xml
diff --git a/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/ParentProcessWatcher.java b/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/ParentProcessWatcher.java
@@ -88,9 +88,9 @@ private boolean parentProcessStillRunning() {
 
 		String command;
 		if (Platform.OS_WIN32.equals(Platform.getOS())) {
-			command = "cmd /c \"tasklist /FI \"PID eq " + pid + "\" | findstr " + pid + "\"";
+			command = String.format("cmd /c \"tasklist /FI \"PID eq %1$d\" | findstr %1$d\"", pid);
 		} else {
-			command = "kill -0 " + pid;
+			command = String.format("kill -0 %d", pid);
 		}
 		Process process = null;
 		boolean finished = false;