Avoid string concatenation with Runtime.getRuntime().exec(..).

Signed-off-by: Roland Grunberg <[email protected]>
rgrunber · Jan 12, 2024 · 0e8e17b · 0e8e17b
1 parent 492a32d
commit 0e8e17b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/ParentProcessWatcher.java b/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/ParentProcessWatcher.java
@@ -88,9 +88,9 @@ private boolean parentProcessStillRunning() {
 
 		String command;
 		if (Platform.OS_WIN32.equals(Platform.getOS())) {
-			command = "cmd /c \"tasklist /FI \"PID eq " + pid + "\" | findstr " + pid + "\"";
+			command = String.format("cmd /c \"tasklist /FI \"PID eq %1$d\" | findstr %1$d\"", pid);
 		} else {
-			command = "kill -0 " + pid;
+			command = String.format("kill -0 %d", pid);
 		}
 		Process process = null;
 		boolean finished = false;

diff --git a/org.eclipse.jdt.ls.target/org.eclipse.jdt.ls.tp.target b/org.eclipse.jdt.ls.target/org.eclipse.jdt.ls.tp.target
@@ -63,4 +63,4 @@
 	    </location>
     </locations>
     <targetJRE path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-17"/>
-</target>
+</target>