Fix: Join/Leave sounds don't play for you when you join/leave #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insertish
reviewed
Sep 20, 2022
Comment on lines
+98
to
+100
| if (voiceState.connecting) { | ||
| state.settings.sounds.playSound("call_join"); | ||
| } |
There was a problem hiding this comment.
Any re-render would cause the sound to play more than once here, I think this should be moved somewhere else.
|
Closing due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure to check the following tasks before opening and submitting a PR
This PR just fixes a small bug where the join/leave voice call sounds don't play for you when you join/leave a call #760 (comment). (I haven't included screenshots because of the nature of the change).