feat: use user_info API to check tokens DD-4674

CHANGELOG.md

@@ -4,4 +4,8 @@
 
 ## 0.5.1
 
-* Use POST method for `token_info` request
+* Use POST method for `token_info` request
+
+## 0.5.2
+
+* Use GET `user_info` to check tokens

lib/panda.rb

@@ -25,8 +25,14 @@ def make_request(request)
         conn.response :json
       end
 
-      response = connection.run_request(request.method, request.url, request.params, request.headers)
+      response = do_request(connection, request)
       Panda::HTTPResponse.new(response.status, response.headers, response.body)
     end
+
+    def do_request(connection, request)
+      return connection.post(request.url, request.params, request.headers) if request.method == :post
+
+      connection.get(request.url, request.params, request.headers)
+    end
   end
 end

lib/panda/client.rb

@@ -5,7 +5,7 @@
 require 'panda/errors'
 require 'panda/http_request'
 require 'panda/http_response'
-require 'panda/token_info'
+require 'panda/item'
 
 module Panda
   class Client
@@ -53,6 +53,11 @@ def report(advertiser_id, report_type, dimensions, params = {})
       )
     end
 
+    def user_info
+      get_user('user/info/')
+    end
+
+    # requires token from Accounts API
     def token_info
       get_token(
         'tt_user/token_info/get/',
@@ -63,9 +68,14 @@ def token_info
 
     private
 
+    def get_user(path, params = {})
+      request = Panda::HTTPRequest.new('GET', path, params, 'Access-Token' => access_token)
+      Panda::Item.new(Panda.make_request(request))
+    end
+
     def get_token(path, params = {})
       request = Panda::HTTPRequest.new('POST', path, params)
-      Panda::TokenInfo.new(Panda.make_request(request))
+      Panda::Item.new(Panda.make_request(request))
     end
 
     def get_collection(path, params = {})

lib/panda/token_info.rb → lib/panda/item.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Panda
-  class TokenInfo
+  class Item
     attr_reader :data
 
     def initialize(response)

lib/panda/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Panda
-  VERSION = '0.5.1'
+  VERSION = '0.5.2'
 end

spec/cases/client_spec.rb

@@ -40,6 +40,14 @@
     end
   end
 
+  describe '#user_info' do
+    it 'calls #get_user' do
+      expect(subject).to receive(:get_user).with('user/info/')
+
+      subject.user_info
+    end
+  end
+
   describe '#token_info' do
     it 'calls #get_token' do
       expect(subject)

spec/cases/item_spec.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Panda::Item do
+  let(:response) { Panda::HTTPResponse.new(200, {}, response_body) }
+
+  context 'when item is token info' do
+    let(:response_body) do
+      {
+        'message' => 'OK',
+        'code' => 0,
+        'data' => {
+          'app_id' => Panda.config.app_id,
+          'creator_id' => 'test_creator_id',
+          'scope' => 'user.info.basic'
+        },
+        'request_id': '2020031009181201018904922342087A16'
+      }
+    end
+
+    it 'gets token info' do
+      token_info = described_class.new(response)
+
+      expect(token_info['creator_id']).to eq('test_creator_id')
+      expect(token_info['scope']).to eq('user.info.basic')
+    end
+  end
+
+  context 'item is user info' do
+    let(:response_body) do
+      {
+        'message' => 'OK',
+        'code' => 0,
+        'data' => {
+          'display_name' => 'user_name',
+          'email' => '[email protected]',
+          'core_user_id' => 'core_user_id',
+          'avatar_url' => 'https://example.com/avatar.jpg'
+        },
+        'request_id': '2020031009181201018904922342087A16'
+      }
+    end
+
+    it 'gets user info' do
+      user_info = described_class.new(response)
+
+      expect(user_info['display_name']).to eq('user_name')
+      expect(user_info['email']).to eq('[email protected]')
+    end
+  end
+end