Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I strongly believe in my approach to solve the SDL naming and mapping confusion and also prevent the recent .m3u issues, I'd like you to have a look to this script. Instead of creating profiles with fixed gamepads (not working if you have more than one gamepad with the same name), generate a profile where the device name can be appended on the fly after checking at start time the list of connected controllers.
Supports also switching Wiimote setup (only Wiimote, Sideways Wiimote, Classic Controller and Wiimote+Nunchuk at the moment).
With this, the P1 will also be able to quit the game by pressing Guide+A+B
Of course we still need to address keyboard configurations, but I think gamepads have the priority at the moment.
==== THE FOLLOWING HAS BEEN WRITTEN BY COPILOT (I wanted to try it out, and it seems it's working fine)
This pull request includes significant changes to the Dolphin emulator configuration and joystick mapping scripts. The main focus is on introducing a new Python launcher script for Dolphin, updating the emulator configuration in
dolphin.sh
, and enhancing the joystick mapping logic inemulationstation/configscripts/dolphin.sh
.Emulator Configuration Changes:
configure_dolphin
function to usedolphin_launcher.py
for launching games, and adjusted the emulator entries accordingly.dolphin.sh
withdolphin_launcher.py
.New Python Launcher Script:
dolphin_launcher.py
which handles game launching, controller configuration, and hotkey management. This script uses SDL2 for game controller detection and configparser for managing configuration files.Joystick Mapping Enhancements:
emulationstation/configscripts/dolphin.sh
.map_dolphin_joystick
function to support both GameCube and Wii controllers, including new key mappings and translation logic for input values. [1] [2] [3]onend_dolphin_joystick
function to handle the new configuration files and apply additional joystick calibration settings. [1] [2]