-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing GetFileVersionInfo*Ex* funcs #941
Conversation
8bae7e2
to
56fe305
Compare
166e32c
to
6439019
Compare
Relevant header code: winver.h
verrsrc.h
According to the contribution guidelines shouldn't the struct and consts go in a new verrsrc.rs file?
Also, the parameter name for Other than that, LGTM |
Thanks for the review, will fix. |
I took the opportunity to fix some other small mistakes in the winver.rs files (that were backward-compatible). I applied the requested changes, and further changed |
I think CI failed because of using |
3c683dc
to
40d0e56
Compare
0402b19
to
5dedd8f
Compare
This is ready now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#906 turns out there's an existing PR that's more complete than this one. This should be merged instead. |
Add a handful of missing functions from winver.h, namely GetFileVersionInfo(Size)?Ex(W|A), and the associated constant flags.