Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add definitions from oleacc.h #883

Closed
wants to merge 3 commits into from
Closed

Add definitions from oleacc.h #883

wants to merge 3 commits into from

Conversation

DataTriny
Copy link

Hello,

This PR adds all definitions from oleacc.h, as well as a new oleacc feature.

This is a requirement for UI Automation support, for which I already started the translation.

Things I am not really confident with are the function pointers on top of the file.

@retep998 retep998 added the waiting on review Waiting for a reviewer to review the PR label May 3, 2020
@mwcampbell
Copy link

The function pointer type declarations at the top of oleacc.rs (using the FN! macro) look OK to me, but then I'm new to Rust.

I notice a couple of problems with the pub fn declarations below:

  1. They should be enclosed in extern "system", not extern "C", since they use the stdcall calling convention, not cdecl.
  2. The functions that are declared using STDAPI in the C header file return an HRESULT; oleacc.rs currently declares no return types for those.

That's what I've found so far.

@DataTriny DataTriny closed this by deleting the head repository Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting on review Waiting for a reviewer to review the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants