add IAudioClient2+3 #868
Closed
add IAudioClient2+3 #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
just realized #796 looks like a more complete PR, but leaving this open as my vote to consider merging these new audio features :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the amazing crate!
This PR adds IAudioClient2+3 which allow for lower-latency (down to 128 frame buffer size) while staying in shared mode. I have this working locally with a fork of cpal.
https://docs.microsoft.com/en-us/windows/win32/api/audioclient/nn-audioclient-iaudioclient3 (requires Windows 10)
https://docs.microsoft.com/en-us/windows/win32/api/audioclient/nn-audioclient-iaudioclient2 (requires Windows 8)
Do things need to be
cfg'ed out based on feature/windows version?