ci: don't install unnecessary deps #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the ci script is referenced in CONTRIBUTING.md as an example, so keep dependencies to a minimal. also use meta-package like "build-base" on alpine instead of installing binutils, make etc seperately.
|
I noticed that there were couple warnings from github
Upgrading the If it's using semantic versioning scheme, then wouldn't it be better to do just |
use v4 rather than hardcoding minor+patch version as well.
N-R-K
merged commit 07424e2
into
resurrecting-open-source-projects:master
18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the ci script is referenced in CONTRIBUTING.md as an example, so keep dependencies to a minimal.
also use meta-package like "build-base" on alpine instead of installing binutils, make etc seperately.