Automatically sync playground URL #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fhammerschmidt
approved these changes
Nov 12, 2024
|
any reason why you deleted the Next.resi? |
@fhammerschmidt I guess Next.res (and before Next.re) originally had some runtime code, now it's pure bindings so the interface file is redundant and actually the interface file was even wrong because it used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, Copy Share Link button is a bit broken, it reloads the whole page.
So I used shallow replace to avoid that. Since syncing the URL was then almost instant, I thought that syncing the URL while typing or on version/module system switch would be nice too so I implemented it.