Remove check for inner nullability of component columns #9009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes connection to redap server
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
emilk
added
🪳 bug
|
|
teh-cmc
approved these changes
Feb 12, 2025
teh-cmc
reviewed
Feb 12, 2025
| return Err(ChunkError::Malformed { | ||
| reason: format!( | ||
| "The outer array in a chunked component batch must be a sparse list, got {:?}", | ||
| "The inner array in a chunked component batch must be a list, got {:?}", |
There was a problem hiding this comment.
This is not the inner array, this is the outer list_array, i.e. the column
jprochazk
pushed a commit
that referenced
this pull request
Feb 13, 2025
### Related * #8998 * #6819 ### What `pixi run rerun rerun://redap.rerun.io/catalog` failed with `Detected malformed Chunk: The outer array in chunked component batch must be a sparse list, got List(Field { name: "item", data_type: Utf8, nullable: false, dict_id: 0, dict_is_ordered: false, metadata: {} })`. The cause was a check in the `Chunk::sanity_check` requiring _inner mutability_, i.e. allowing a single component to be null in a list. The intention of the check was to check for _outer_ nullability, i.e. that any cell in the column can be `null` (or a dense list). In other words, we want to support `Vec<Option<Vec<T>>`, but NOT require `Vec<Option<Vec<Option<T>>>`. Why did this trigger now? Because we now allow sending component columns as "mono components", i.e. as `Vec<T>` and that is then automatically changed to `Vec<Vec<T>>`, but wether or not it has interior nullability depends on if the source data had it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
wrap_in_list_array#8998What
pixi run rerun rerun://redap.rerun.io/catalogfailed withDetected malformed Chunk: The outer array in chunked component batch must be a sparse list, got List(Field { name: "item", data_type: Utf8, nullable: false, dict_id: 0, dict_is_ordered: false, metadata: {} }).The cause was a check in the
Chunk::sanity_checkrequiring inner mutability, i.e. allowing a single component to be null in a list. The intention of the check was to check for outer nullability, i.e. that any cell in the column can benull(or a dense list).In other words, we want to support
Vec<Option<Vec<T>>, but NOT requireVec<Option<Vec<Option<T>>>.Why did this trigger now? Because we now allow sending component columns as "mono components", i.e. as
Vec<T>and that is then automatically changed toVec<Vec<T>>, but wether or not it has interior nullability depends on if the source data had it.