Fix: --serve-web should consume data sources
#9004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprochazk
added
🕸️ web
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
jprochazk
commented
Feb 12, 2025
| @@ -27,6 +27,8 @@ use tower_http::cors::CorsLayer; | |||
| pub const DEFAULT_SERVER_PORT: u16 = 9876; | |||
| pub const DEFAULT_MEMORY_LIMIT: MemoryLimit = MemoryLimit::UNLIMITED; | |||
|
|
|||
| // TODO(jan): Refactor `serve`/`spawn` variants into a builder? | |||
There was a problem hiding this comment.
I keep adding more of these. It's unlikely to increase any further, but if it does I'll refactor it into more of a builder.
teh-cmc
approved these changes
Feb 13, 2025
jprochazk
force-pushed
the
jan/fix-serve-web-file
branch
from
f94869f to
20e2fd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
rerun --web-viewer file.rrdno longer loads rrd #9002What
Previously we would create a
RerunServerfromrxsbefore serving the Web Viewer. The gRPC server that's started by--serve-webwill now consumerxsas well. It can still be sent additional data viaconnect_grpcin our SDKs, even after it consumes its initial data sources.Tested with (from linked issue):