Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snapshot test for the help view #8955

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Add snapshot test for the help view #8955

merged 2 commits into from
Feb 7, 2025

Conversation

lucasmerlin
Copy link
Contributor

Related

Done seperately from #8947 so it doesn't block the release

@lucasmerlin lucasmerlin added 🔨 testing testing and benchmarks exclude from changelog PRs with this won't show up in CHANGELOG.md labels Feb 6, 2025
Copy link

github-actions bot commented Feb 6, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
9d62cf6 https://rerun.io/viewer/pr/8955 +nightly +main

Note: This comment is updated whenever you push a commit.

Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

@teh-cmc teh-cmc self-assigned this Feb 7, 2025
@teh-cmc
Copy link
Member

teh-cmc commented Feb 7, 2025

Please scope the branch name next time @lucasmerlin 🙏 e.g. lucas/help-view-tests

@teh-cmc teh-cmc merged commit bb18071 into main Feb 7, 2025
29 of 31 checks passed
@teh-cmc teh-cmc deleted the help-view-tests branch February 7, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🔨 testing testing and benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants