Deprecate C++ TimeColumn::from_sequence_points in favor of TimeColumn::from_sequence
#8882
+24
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
changed the title
TimeColumn::from_sequenceTimeColumn::from_sequence_points in favor of TimeColumn::from_sequence
Wumpf
force-pushed
the
andreas/cpp/rename-time-seq
branch
from
3af1b1d to
d6811e4
Compare
…n::from_sequence`
Wumpf
force-pushed
the
andreas/cpp/rename-time-seq
branch
from
d6811e4 to
197e009
Compare
teh-cmc
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Equivalent in the other SDKs:
TimeColumn::new_sequencererun.TimeSequenceColumnfrom_sequence_pointswas called that way to make clear it's about time points, but figuring now that overall this is more in the way than helpful.