Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even less arrow2 #8719

Merged
merged 12 commits into from
Jan 17, 2025
Merged

Even less arrow2 #8719

merged 12 commits into from
Jan 17, 2025

Conversation

emilk
Copy link
Member

@emilk emilk commented Jan 16, 2025

Just one small piece at a time

@emilk emilk added 🏹 arrow concerning arrow 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jan 16, 2025
@emilk
Copy link
Member Author

emilk commented Jan 16, 2025

@rerun-bot full-check

Copy link

github-actions bot commented Jan 16, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
1e6ceea https://rerun.io/viewer/pr/8719 +nightly +main

Note: This comment is updated whenever you push a commit.

Copy link

@emilk
Copy link
Member Author

emilk commented Jan 16, 2025

@rerun-bot full-check

Copy link

@emilk emilk force-pushed the emilk/arrow-col-descr branch from 28996f3 to 0efbc08 Compare January 16, 2025 19:26
@emilk
Copy link
Member Author

emilk commented Jan 16, 2025

@rerun-bot full-check

Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/12816179269

@emilk emilk marked this pull request as ready for review January 16, 2025 19:30
@teh-cmc teh-cmc self-requested a review January 17, 2025 08:23
@emilk
Copy link
Member Author

emilk commented Jan 17, 2025

@rerun-bot full-check

Copy link

@emilk emilk merged commit fdf065f into main Jan 17, 2025
30 of 31 checks passed
@emilk emilk deleted the emilk/arrow-col-descr branch January 17, 2025 10:56
zehiko pushed a commit that referenced this pull request Jan 21, 2025
### Related
* #8719

Apparently `arrow::Datatype::to_string/parse` doesn't roundtrip, despite
claiming so. Let's hope serde/json works better.

We probably want to replace the whole of
`crates/store/re_protos/proto/rerun/v0/common.proto` with just a
IPC-encoded RecordBath at some point, but not today.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏹 arrow concerning arrow exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants