Fix performance regression due to extra arrow round-tripping #8684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not 100% sure why this happenes. It looks like roundtripping `ListArray` marks the inner datatype field as nullable, even when it wasn't originally. I'm taking a look at fixing this in `re_arrow2`, but I wanted to open this quick-fix in the meantime. * Closes #8668 * Introduced in PR #8617 * Introduced in commit 78f676f
emilk
added
🏹 arrow
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
Wumpf
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure why this happenes.
It looks like roundtripping
ListArraymarks the inner datatype field as nullable, even when it wasn't originally.I'm taking a look at fixing this in
re_arrow2, but I wanted to open this quick-fix in the meantime.PendingRowtoarrow-rs#8617