Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor TimeColumnDescriptor #8658

Merged
merged 5 commits into from
Jan 14, 2025
Merged

Refactor TimeColumnDescriptor #8658

merged 5 commits into from
Jan 14, 2025

Conversation

emilk
Copy link
Member

@emilk emilk commented Jan 11, 2025 •
edited
Loading

@emilk emilk added 🏹 arrow concerning arrow 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jan 11, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 11, 2025 •
edited
Loading

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
✅ f253b52 https://rerun.io/viewer/pr/8658 +nightly +main

Note: This comment is updated whenever you push a commit.

@emilk emilk changed the title Remove TimeColumnDescriptor::datatype Refactor TimeColumnDescriptor Jan 13, 2025
@emilk emilk marked this pull request as draft January 13, 2025 10:08
@emilk
Copy link
Member Author

emilk commented Jan 13, 2025

@rerun-bot full-check

@github-actions GitHub Actions
Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/12745055150

@emilk emilk marked this pull request as ready for review January 13, 2025 10:17
@emilk emilk requested a review from teh-cmc January 13, 2025 10:17
@emilk emilk merged commit 1ffe586 into main Jan 14, 2025
64 of 67 checks passed
@emilk emilk deleted the emilk/remove-timeline-descr-datatype branch January 14, 2025 08:55
emilk added a commit that referenced this pull request Jan 14, 2025
@emilk
Revert "Refactor TimeColumnDescriptor (#8658)"
d85db09 
This reverts commit 1ffe586.
@emilk emilk mentioned this pull request Jan 14, 2025
Merged
emilk added a commit that referenced this pull request Jan 14, 2025
@emilk
Partially revert TimeColumnDescriptor refactor (#8685)
d4f99a1 
* Reverts #8658
* Why? Because it conflicted with
#8651
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh-cmc teh-cmc teh-cmc approved these changes

Assignees
No one assigned
Labels
🏹 arrow concerning arrow exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @teh-cmc