Corrects application name for EC lab vendor portal metadata #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Updates metadata for Vendor Portal setup in "Delivering..." lab
Details
Provides a quick fix to a bug that was preventing the "Delivering Your
Application as a Kubernetes Appliance" lab from starting. The track setup was
failing because the vendor metadata used the name "SlackerNews" and the
function to the app slug defaults to "Slackernews".
The natural fix would have been to avoid the default, but there seems to be a
call to
get_app_slugembedded elsewhere that would blank the value again. Idon't love the inconsistency, but this approach gets the lab running again.
TODO
Dig into this problenm more deeply to determine if we should either simplify
the Vendor Portal setup or track down the code that blanks the app slug.