Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behavior of RunWithOptions when wait is set #87

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Fix behavior of RunWithOptions when wait is set #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,14 @@ func (r *Client) RunWithOptions(ctx context.Context, identifier string, input Pr
return nil, err
}

// Wait for the prediction to complete
err = r.Wait(ctx, prediction)
if err != nil {
return nil, err
// Check if the prediction is done based on blocking preference and status
isDone := options.blockUntilDone && prediction.Status != Starting
if !isDone {
// Wait for the prediction to complete
err = r.Wait(ctx, prediction)
if err != nil {
return nil, err
}
}

// Check for model error in the prediction
Expand Down
Loading