Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WithFileOutput to streaming methods #83

Closed
wants to merge 2 commits into from
Closed

Add WithFileOutput to streaming methods #83

wants to merge 2 commits into from

Conversation

mattt
Copy link
Contributor

@mattt mattt commented Sep 23, 2024

No description provided.

@mattt mattt marked this pull request as draft September 23, 2024 12:22
@mattt mattt closed this Sep 23, 2024
@mattt mattt deleted the mattt/stream-file branch September 23, 2024 12:22
@mattt
Copy link
Contributor Author

mattt commented Sep 23, 2024

This approach doesn't quite work because the data field in ServerSentEvent objects is a string, and therefore no value to downloading into FileObject only to re-encode in base64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mattt