Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling and resource management in streamPrediction #79

Merged
merged 4 commits into from
Sep 19, 2024
Merged

Improve error handling and resource management in streamPrediction #79

merged 4 commits into from
Sep 19, 2024

Conversation

mattt
Copy link
Contributor

@mattt mattt commented Sep 17, 2024

This PR makes the following improvements to our streaming code:

  • Ensures resp.Body always closes
  • Improve context cancellation handling
  • Add non-blocking send to lineChan and errChan

@mattt mattt requested a review from philandstuff September 17, 2024 21:11
@mattt mattt merged commit 1c2ae68 into main Sep 19, 2024
3 checks passed
@mattt mattt deleted the mattt/update-stream-concurrency branch September 19, 2024 11:55
This was referenced Sep 19, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philandstuff philandstuff philandstuff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattt @philandstuff