Make O_TRUNC use better #152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only use if --force is actually specified
|
This did reduce the delta (minimally) between tar and non-tar mode. I'm not certain this is worth it. @philandstuff thoughts? |
philandstuff
reviewed
Feb 7, 2024
| @@ -4,4 +4,5 @@ import "io" | |||
|
|
|||
| type Consumer interface { | |||
| Consume(reader io.Reader, destPath string) error | |||
| SetOverwriteTarget(force bool) | |||
There was a problem hiding this comment.
eeh, I don't like this interface. We should pass a slice/varargs of ConsumeOptions (of which OverwriteTarget would be one instance) into Consume() instead.
I think if we can tidy up the interface then this is a good idea. I'd also like to see us do the partial file download thing, where we download to a temp file and move to the target once the file is fully written |
|
Superseded by #158 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only use if --force is actually specified