use orchestration service for Chain Abstraction #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Skipped Deployments
|
Added input filed for amount and recipient address
Comment on lines
72
to
78
| const gasEstimate = await chainProvider.estimateGas({ | ||
| from: walletAddress, | ||
| to: transaction.to, | ||
| value: transaction.value, | ||
| data: transaction.data, | ||
| gasPrice: gasPrice | ||
| }) |
There was a problem hiding this comment.
Why do we do this? isn't this done server side?
There was a problem hiding this comment.
added the server-side value.
| gasPrice: gasPrice | ||
| }) | ||
|
|
||
| const hash = await chainConnectedWallet.sendTransaction({ |
There was a problem hiding this comment.
Should we include nonce because we're doing manual nonce calculation backend side?
There was a problem hiding this comment.
Yes, I'll add the nonce. I encountered an error indicating a "nonce value too high" (Max is working on fixing its nonce calculation).
There was a problem hiding this comment.
Nonce calculation got resolved. I will add it.
lukaisailovic
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CA implementation using orchestration service.
UserInterface improvement on CA demo app.