Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Replace single - subscription stream in _channel creation with broadcast stream #94

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pye52
Copy link

@pye52 pye52 commented Feb 5, 2025

Due to _channel = _socket!.cast<String>(), the _channel will be assigned to CloseGuaranteeChannel. Inside the listen method of CloseGuaranteeChannel, there is a line of code:

var subscription = _inner.listen(onData,
        onError: onError, onDone: onDone, cancelOnError: cancelOnError);

When this _inner.listen method is called multiple times, it will also throw the Bad state: Stream has already been listened to error.

@quetool
Copy link
Member

quetool commented Feb 5, 2025

Hello @pye52! Your mentioned issue has already been fixed by @AlexV525 with this PR #67 which should already been included in reown_core: 1.1.1

Can you check it and comment your thoughts if needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants