Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WalletKit] TVF #89

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

[WalletKit] TVF #89

wants to merge 12 commits into from

Conversation

quetool
Copy link
Member

@quetool quetool commented Jan 22, 2025 •
edited
Loading

Description

Implemented TVF logic con Sign/Core SDK.

How Has This Been Tested?

Test logs:

Screenshot 2025-02-05 at 14 39 11

Due Dilligence

  • Breaking change
  • Requires a documentation update

@quetool quetool force-pushed the feature/walletkit_tvf branch from e43fa46 to ece3f98 Compare January 24, 2025 15:29
@quetool quetool marked this pull request as ready for review January 24, 2025 15:33
@jakubuid
Copy link 

[WalletKit] 2025-01-24 16:17:06.670496 📝 [RelayClient] publish 1109, correlation_id: 1737731811708161, tvf: {rpc_methods: [solana_signTransaction], chain_id: solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp, contract_addresses: null, tx_hashes: [{signature: 3tgtwvMPQTMHs9hmWVEe59Go55rqrbdNsXTMrpJrP4mrAaBXwqKbbAi4C6c4h55nzYdDwMaccvdzis98pDooqNeB}]}

txHashes are supposed to be a list of strings, according to tech doc @quetool

@quetool
Copy link
Member Author

quetool commented Jan 27, 2025 

[WalletKit] 2025-01-24 16:17:06.670496 📝 [RelayClient] publish 1109, correlation_id: 1737731811708161, tvf: {rpc_methods: [solana_signTransaction], chain_id: solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp, contract_addresses: null, tx_hashes: [{signature: 3tgtwvMPQTMHs9hmWVEe59Go55rqrbdNsXTMrpJrP4mrAaBXwqKbbAi4C6c4h55nzYdDwMaccvdzis98pDooqNeB}]}

txHashes are supposed to be a list of strings, according to tech doc @quetool

Sounds fair! Since Solana has different response object I thought the whole response was needed. I'll change it.

@quetool quetool requested a review from jakubuid January 27, 2025 12:22
@quetool quetool force-pushed the feature/walletkit_tvf branch from 4740516 to 73c955a Compare January 29, 2025 14:27
@quetool quetool changed the base branch from develop to master February 4, 2025 14:49
@quetool quetool changed the base branch from master to develop February 4, 2025 14:51
@quetool quetool force-pushed the feature/walletkit_tvf branch 2 times, most recently from 8a6dd68 to 6ee2850 Compare February 5, 2025 11:10
@quetool quetool force-pushed the feature/walletkit_tvf branch from 6ee2850 to 9f681d5 Compare February 5, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llbartekll llbartekll Awaiting requested review from llbartekll

@ganchoradkov ganchoradkov Awaiting requested review from ganchoradkov

@jakubuid jakubuid Awaiting requested review from jakubuid

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quetool @jakubuid